Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path variable export for gmake 3.81 (#110) #110

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: path variable export for gmake 3.81 (#110) #110

merged 1 commit into from
Oct 29, 2024

Conversation

tkrop
Copy link
Owner

@tkrop tkrop commented Oct 29, 2024

This pull request adds a hack for the problem that a changed PATH environment variable is no correctly exported to $(shell ...) calls and subsequently also to target executions prior to gmake version 4. This is necessary since MacOS is by default running the outdated gmake 3.81+.

See also https://stackoverflow.com/questions/8941110/how-i-could-add-dir-to-path-in-makefile

The pull request also improves the compliance of the git-verify-target with the conventional commit message format and improves the related documentation and fixes link issues.

Copy link

codacy-production bot commented Oct 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (789990d) 190 190 100.00%
Head commit (5e0ae37) 190 (+0) 190 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#110) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tkrop tkrop self-assigned this Oct 29, 2024
@tkrop tkrop added the enhancement New feature or request label Oct 29, 2024
tkrop added a commit that referenced this pull request Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11573152706

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11420095292: 0.0%
Covered Lines: 190
Relevant Lines: 190

💛 - Coveralls

tkrop added a commit that referenced this pull request Oct 29, 2024
@tkrop tkrop merged commit f0ac228 into main Oct 29, 2024
11 of 12 checks passed
@tkrop tkrop deleted the path-export branch October 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants